[FFmpeg-devel] [PATCH v3 2/6] lavc/av1: Add common code and unit test for level handling

James Almer jamrial at gmail.com
Mon Aug 7 15:40:23 EEST 2023


On 8/3/2023 3:01 AM, fei.w.wang-at-intel.com at ffmpeg.org wrote:
> From: Fei Wang<fei.w.wang at intel.com>
> 
> Signed-off-by: Fei Wang<fei.w.wang at intel.com>
> ---
> update:
> 1. Rename libavcodec/av1_levels*.
> 2. Use array instead of handle for AV1LevelDescriptor.name.
> 3. Compile libavcodec/av1_levels* only when enable vaapi av1 encoder.
> 
>   libavcodec/Makefile           |   1 +
>   libavcodec/av1_levels.c       |  92 +++++++++++++++++++++++++
>   libavcodec/av1_levels.h       |  58 ++++++++++++++++
>   libavcodec/tests/.gitignore   |   1 +
>   libavcodec/tests/av1_levels.c | 124 ++++++++++++++++++++++++++++++++++
>   tests/fate/libavcodec.mak     |   5 ++
>   6 files changed, 281 insertions(+)
>   create mode 100644 libavcodec/av1_levels.c
>   create mode 100644 libavcodec/av1_levels.h
>   create mode 100644 libavcodec/tests/av1_levels.c
> 
> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> index 3c16b51462..a6b2ecbb22 100644
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -1319,6 +1319,7 @@ TESTPROGS = avcodec                                                     \
>               jpeg2000dwt                                                 \
>               mathops                                                    \
>   
> +TESTPROGS-$(CONFIG_AV1_VAAPI_ENCODER)     += av1_levels

This encoder does not exist at the point this patch would be applied. 
It's introduced in patch 6/6.

Squash libavcodec/av1_levels.c into patch 6/6 (Its first user), and then 
add the test in a new patch 7.


More information about the ffmpeg-devel mailing list