[FFmpeg-devel] [PATCH 1/2] doc/developer: Reviews must be constructive

Michael Niedermayer michael at niedermayer.cc
Thu Aug 24 22:56:14 EEST 2023


Suggested text is from Anton

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 doc/developer.texi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/developer.texi b/doc/developer.texi
index 0c2f2cd7d1..383120daaa 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -853,6 +853,9 @@ Everyone is welcome to review patches. Also if you are waiting for your patch
 to be reviewed, please consider helping to review other patches, that is a great
 way to get everyone's patches reviewed sooner.
 
+Reviews must be constructive and when rejecting a patch the reviewer must explain
+their reasons and ideally suggest an alternative approach.
+
 @anchor{Regression tests}
 @chapter Regression tests
 
-- 
2.17.1



More information about the ffmpeg-devel mailing list