[FFmpeg-devel] [PATCH 2/2] doc/developer: Code pushed without patches on ffmpeg-devel must be announced on the ML
Jean-Baptiste Kempf
jb at videolan.org
Fri Aug 25 18:36:08 EEST 2023
On Fri, 25 Aug 2023, at 17:34, Michael Niedermayer wrote:
> On Thu, Aug 24, 2023 at 10:04:16PM +0200, Andreas Rheinhardt wrote:
>> Michael Niedermayer:
>> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>> > ---
>> > doc/developer.texi | 9 +++++++++
>> > 1 file changed, 9 insertions(+)
>> >
>> > diff --git a/doc/developer.texi b/doc/developer.texi
>> > index 383120daaa..1c0091fc74 100644
>> > --- a/doc/developer.texi
>> > +++ b/doc/developer.texi
>> > @@ -856,6 +856,15 @@ way to get everyone's patches reviewed sooner.
>> > Reviews must be constructive and when rejecting a patch the reviewer must explain
>> > their reasons and ideally suggest an alternative approach.
>> >
>> > +If a change is pushed without being sent to ffmpeg-devel, the developer
>> > +pushing it must annouce doing so on the ffmpeg-devel mailing list immedeatly.
>> > + at example
>> > +forgot a semicolon in this patch, pushed a seperate fix
>> > +pushed my new autograd engine and stable diffusion filter. Didnt want to
>> > +go through the bikeshed if that belongs in FFmpeg, go to the GA if you want
>> > +it removed. Otherwise Just tell me what i should improve and ill look into it.
>> > + at end example
>>
>> This encourages pushing patches (even completely new filters) without
>> sending them to the ML.
>
> That was not the intend but if you look at "cvslog" and ffmpeg-devel, you will
> notice that there are things being pushed that have not been seen on the
> ffmpeg-devel mailing list.
So that means mandatory sending to the mailing list :)
--
Jean-Baptiste Kempf - President
+33 672 704 734
More information about the ffmpeg-devel
mailing list