[FFmpeg-devel] [PATCH] OSQ lossless audio format support

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Wed Aug 30 01:20:16 EEST 2023


Paul B Mahol:
> +    st->codecpar->sample_rate = AV_RL32(st->codecpar->extradata + 4);
> +    if (st->codecpar->sample_rate <= 0)
> +        return AVERROR_INVALIDDATA;
> +    av_channel_layout_uninit(&st->codecpar->ch_layout);

Unnecessary: This channel layout belongs to an AVCodecParameters from a
freshly created AVStream; of course the channel layout is equivalent to
an uninited one.

> +    st->codecpar->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC;
> +    st->codecpar->ch_layout.nb_channels = st->codecpar->extradata[3];



More information about the ffmpeg-devel mailing list