[FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

Stefano Sabatini stefasab at gmail.com
Thu Aug 31 20:16:20 EEST 2023


On date Thursday 2023-08-31 18:51:52 +0200, Andreas Rheinhardt wrote:
> Stefano Sabatini:
> > +int sws_get_gaussian_vec(SwsVector **vecp,
> > +                         AVClass *log_ctx,
> > +                         double standard_deviation, double quality);
> >  
> 
> Seriously? A pointer to an AVClass as log_ctx? It is actually AVClass**
> (the logcontext must have a pointer to an AVClass as its first member),
> but we always use NULL.

Sorry, sloppy editing on my side.

> Apart from that: I am not really convinced that the improvement is worth
> the hassle.

This is not a high-profile function (probably it's never used outside
lavfi) and provides an opportunity to move the API to the correct
direction.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lsws-swscale.h-introduce-sws_get_gaussian_vec.patch
Type: text/x-diff
Size: 5796 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230831/3c9ae5d5/attachment.patch>


More information about the ffmpeg-devel mailing list