[FFmpeg-devel] [PATCH 1/6] lavc/aarch64: new optimization for 8-bit hevc_pel_bi_pixels

[Martin Storsjö]

On Fri, 24 Nov 2023, Martin Storsjö wrote:

> Hi Logan,
>
> On Fri, 24 Nov 2023, Logan.Lyu wrote:
>
>> And  can you try those .patch files I attached in every email?  I 
>> downloaded the attachment from the ffmpeg-devel mailing list I subscribed 
>> to and applied it, and it seems to work.
>
> Oh, I see - I didn't notice the attached patch. As the patch also was sent 
> inline, I only tried to apply the full mail as a patch (which had corrupted 
> whitespace somewhere), but the attached patch files did work. Now I've 
> successfully applied your patchset, so I can start testing and reviewing it 
> when I get time for it. Thanks!

I had a look at the patchset now, it looked mostly good.

I fixed most of the trivial issues I noticed, and pushed with that.

Please have a look at the comments I made, in particular, the weird

+        mov             x8, #32
+        str             x8, [sp, #-80]!

in patch 5/6 is left untouched as is. Feel free to propose follow-up 
patches to fix that. I also didn't try to tweak the scheduling of e.g. the 
subs instructions.

// Martin