[FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24

flow gg hlefthleft at gmail.com
Fri Dec 1 22:16:27 EET 2023


I forgot to modify the Makefile; I've made the changes in this reply.

flow gg <hlefthleft at gmail.com> 于2023年12月2日周六 03:50写道:

> Okay, changed and attached
>
> Rémi Denis-Courmont <remi at remlab.net> 于2023年12月2日周六 02:38写道:
>
>> Le perjantaina 1. joulukuuta 2023, 20.35.10 EET Rémi Denis-Courmont a
>> écrit :
>> > Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a écrit :
>> > > Okay, changed
>> >
>> > src/libavcodec/riscv/ac3dsp_init.c: In function ‘ff_ac3dsp_init_riscv’:
>> > src/libavcodec/riscv/ac3dsp_init.c:39:33: warning: assignment to ‘void
>> (*)
>> > (int32_t *, const float *, size_t)’ {aka ‘void (*)(int *, const float *,
>> > long unsigned int)’} from incompatible pointer type ‘void (*)(int32_t *,
>> > const float *, unsigned int)’ {aka ‘void (*)(int *, const float *,
>> unsigned
>> > int)’} [- Wincompatible-pointer-types]
>> >    39 |             c->float_to_fixed24 = ff_float_to_fixed24_rvv;
>> >
>> >       |                                 ^
>> >
>> > Also the Makefile precondition is inaccurate.
>>
>> Oh, and on C908, LMUL=8 is actually faster than LMUL=4. Generally
>> speaking,
>> you should maximise the LMUL unless there is a *specific* reason not to.
>>
>> --
>> レミ・デニ-クールモン
>> http://www.remlab.net/
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavc-ac3dsp-R-V-V-float_to_fixed24.patch
Type: text/x-patch
Size: 3664 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231202/eca25fe1/attachment.bin>


More information about the ffmpeg-devel mailing list