[FFmpeg-devel] [PATCH 1/7] avutil/tests/imgutils: factorize basic tests to new function

Stefano Sabatini stefasab at gmail.com
Sun Dec 3 23:31:41 EET 2023


On date Sunday 2023-12-03 01:27:20 +0100, Marton Balint wrote:
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavutil/tests/imgutils.c | 68 ++++++++++++++++++++++----------------
>  1 file changed, 39 insertions(+), 29 deletions(-)
> 
> diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils.c
> index 748bd6c9d2..f3a433ac4a 100644
> --- a/libavutil/tests/imgutils.c
> +++ b/libavutil/tests/imgutils.c
> @@ -19,6 +19,41 @@
>  #include "libavutil/imgutils.c"
>  
>  #undef printf

> +static int basic_tests(enum AVPixelFormat pix_fmt, int w, int h) {

better be descriptive and follow the usual VERB_OBJECT convention,
this might be:
static inst check_image_fill(...)

[...]

LGTM otherwise.


More information about the ffmpeg-devel mailing list