[FFmpeg-devel] [PATCH 13/13 v3] fftools/ffmpeg: convert to a threaded architecture

Nicolas George george at nsup.org
Mon Dec 4 18:37:23 EET 2023


Anton Khirnov (12023-12-04):
> broken. If that extra buffering is an actual problem for someone, it can
> be easily avoided by opening the file twice.

Not a solution if the file is streamed or generated.

> As I said before, your command does NOT work. Its output changes
> unpredictably depending on unrelated parameters.

It still produces correct output in most of the cases, which is what
matters to users.

> I maintain that your demand to "fix" your testcase (i.e. reduce its
> memory consumption) is highly unreasonable –

My demand is not that you REDUCE the memory consumption, my demand is
that you DO NOT INCREASE IT HUNDREDFOLD.

That is a perfectly reasonable demand.

>						unless you specify how
> exactly that is supposed to be accomplished while preserving
> determinism.

Fixing the bugs introduced by threading is the job of the person who
wants to introduce threading. I can offer the help of my expertise about
lavfi and subtitles, of course. But your attitude to just pretend the
problem does not exist is unacceptable.

-- 
  Nicolas George


More information about the ffmpeg-devel mailing list