[FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils

[Thilo Borgmann]

Am 14.12.23 um 06:23 schrieb Anton Khirnov:
> Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 19:17:04)
>> Am 13.12.23 um 17:28 schrieb Anton Khirnov:
>>> It is bad practice to design library features around the needs and
>>> limitations of a single specific caller.
>>
>> The callers here would be the CLI and this filter.
> 
> First, public APIs should be designed for general classes of use cases,
> not specific callers.

Parsing a "...{var0}...{varN}..." string for its variables appears quite generic to me.
IMO, especially for libavutil, you think a bit too ideological here.

A) How about putting it under avpriv_ then?
B) Not filibustering about lib design, nor contradictory support of this patch, but use a fixed format. IMHO just sad for the user and a drawback for us not being able to support the same format strings in the CLI & filters without redundant code.

-Thilo