[FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter

Nicolas George george at nsup.org
Wed Dec 20 21:50:50 EET 2023


Vittorio Giovara (12023-12-20):
> If there are no more comments, I'll push this today or tomorrow.

I think the change you made after the last request might go too far, but
I have not had time to look at the code carefully enough to be sure.

If a filter can produce several output frames from one input, then it
must send at lease one of the NEW frames.

An illustration to make it clear: if I1 allows to compute O1a, O1b, O1c,
I2 allows to compute O2a, O2b, O2c, etc.

Then when I1 arrives, the filter must output at least O1a, it can output
O1b and O1c or not.

But when I2 arrives, it must output at lease O2a, which means it must
output O1b and O1c if that was not done at the time of I1.

Your filter only outputs one frame per input, but it seems to me it can
create several frames.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20231220/4b5aa08c/attachment.sig>


More information about the ffmpeg-devel mailing list