[FFmpeg-devel] [PATCH 2/6] checkasm/takdsp: add decorrelate_sr test

[Martin Storsjö]

On Mon, 18 Dec 2023, flow gg wrote:

>

> +static void test_decorrelate_sr(TAKDSPContext *s) {
> +#define BUF_SIZE 1024
> +    declare_func(void, int32_t *, int32_t *, int);
> +
> +    if (check_func(s->decorrelate_sr, "decorrelate_sr")) {
> +        LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
> +        LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
> +        LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]);
> +
> +        randomize(p1, BUF_SIZE);
> +        randomize(p2, BUF_SIZE);
> +        memcpy(p2_2, p2, BUF_SIZE);
> +
> +        call_ref(p1, p2, BUF_SIZE);
> +        call_new(p1, p2_2, BUF_SIZE);
> +
> +        if (memcmp(p2, p2_2, BUF_SIZE) != 0){
> +            fail();
> +        }

This function mutates p1, not p2, so p1 is the one that needs to be copied 
and checked, and memcpy/memcmp need a *sizeof().

// Martin