[FFmpeg-devel] [PATCH major bump 1/6] libavutil/hdr_dynamic_vivid_metadata: fix AVHDRVividColorToneMappingParams

[Anton Khirnov]

Quoting zhilizhao(赵志立) (2023-02-02 09:52:43)
> > On Feb 2, 2023, at 16:16, Anton Khirnov <anton at khirnov.net> wrote:
> > 
> > A major bump is not for breaking APIs however you like, only for things
> > that were scheduled in advance that our callers could have prepared for.
> > You should add new fields, not change existing ones.
> > Also, the documentation and doc/APIchanges need to be updated.
> 
> Adding new fields works, but very ugly.
> 
> The code never work if three_Spline_num > 1. Breaking API to let user
> notice that may not be a bad thing in this specific situation.

Sorry, I disagree. If it could have worked at all - and IIUC it did when
three_Spline_num == 1 - then we should maintain compatibility. The
deprecation notice will notify developers just as well, while
compilation breakage just annoys users who are unable to fix it.

Constant compilation breakage on upgrading to new major versions is one
of the main reasons many of our users bundle old versions of our
libraries with their code. We should avoid unscheduled breakage whenever
possible.

-- 
Anton Khirnov