[FFmpeg-devel] [PATCH 0/6] wavdev: s337m support

[Nicolas Gaullier]

This is the follow up of a past work
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=2593

In my understanding, the code review was running pretty well,
but there was two issues:
- the first one was fixed with the creation of the dolby_e parser
which removed the need of one of the initial patches
- the second one is much embarrassing for me, it is the need
to be able to pass-through s337m (as in current code).
This is typically required to remux s337m to mxf, as there is no s337m submuxer available yet.

And the scope of this option is not clear to me.
I have understood that by default, the s337m demux shall be enabled and I changed my code accordingly.
I also understand we cannot multiply options for every little thing, so I proposed a global option:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20211012154156.1726-2-nicolas.gaullier@cji.paris/
Indeed, it is interesting, for example when using ffprobe as a light "QC" tool and to reject for example
mpegts files that do not have any single PMT, etc.
But I had no answer despite several pings, so I suspect it is not the way to do.

Here, I lastly propose to 'reuse' the AVOption used for s302m as the problem is really similar.
At the end, I find this pretty cool like this... Hope you will like it too!
Anyway, please give me a feedback.

Sample file used for fate:
https://0x0.st/zdW-.wav

Nicolas Gaullier (6):
  avformat/s337m: Split read_packet/get_packet
  avformat/s337m: Consider container bit resolution
  avformat/s337m: New ff_s337m_probe()
  avformat/wavdec: s337m support
  avformat/wavdec.c: Reindent after last commit
  avformat/wavdec: Test s337m

 libavformat/s337m.c      | 71 ++++++++++++++++++++++++++++++++++++----
 libavformat/s337m.h      | 54 ++++++++++++++++++++++++++++++
 libavformat/wavdec.c     | 61 +++++++++++++++++++++++++---------
 tests/Makefile           |  1 +
 tests/fate/audio.mak     |  3 ++
 tests/ref/fate/s337m-wav | 10 ++++++
 6 files changed, 177 insertions(+), 23 deletions(-)
 create mode 100644 libavformat/s337m.h
 create mode 100644 tests/ref/fate/s337m-wav

-- 
2.30.2