[FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc.c: correctly re-emit extradata ahead of IDR pictures

[John Coiner]

On Thu, Feb 16, 2023 at 7:36 PM Marton Balint <cus at passwd.hu> wrote:
>
>
>
> On Sun, 12 Feb 2023, John Coiner wrote:
>
> > This is v2 of the patch for https://trac.ffmpeg.org/ticket/10148.
> >
> > It implements the handling described at http://ffmpeg.org/pipermail/ffmpeg-devel/2023-February/306542.html, that is:
> >  * If we receive [AUD][IDR], we emit [AUD][SPS][PPS][IDR]
> >  * If we receive [SEI][AUD][IDR], we emit [AUD][SPS][PPS][SEI][IDR]
> >
> > This is speculative; it would be good to hear from Marton or others about whether this is the right handling.
>
> Looks fine to me, but I am no expert in H264 either.
>
> Can you check and test the attached patch? It contins cosmetic changes to
> your work. If that looks OK to you as well, than I will apply it in a few
> days.
>
> Thanks,
> Marton
>

Thank you for the cleanups! I reviewed and tested this, it's working
and seems to be equivalent to my last patch. It looks ready to apply.

Cheers,
John