[FFmpeg-devel] [PATCH] tests: actually test yadif's 10 and 16-bit functions

James Darnley jdarnley at obe.tv
Mon Feb 20 15:06:49 EET 2023


On 2/20/23 13:49, Nicolas George wrote:
> James Darnley (12023-02-20):
> 
>> -fate-filter-yadif10: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p10le -frames:v 30 -vf yadif=0,scale
>> -fate-filter-yadif16: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p16le -frames:v 30 -vf yadif=0,scale
>> +fate-filter-yadif10: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p10le -frames:v 30 -vf scale,format=yuv420p10le,yadif=0
>> +fate-filter-yadif16: CMD = framecrc -flags bitexact -idct simple -i $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt yuv420p16le -frames:v 30 -vf scale,format=yuv420p16le,yadif=0
> 
> Moving scale before yadif is right, but format= is redundant with
> -pix_fmt.
> 
> Regards,
> 

So the patch should just be moving the scale filter first?  Sure.  Any 
other comments?  I wait a short while then make that change and push.


More information about the ffmpeg-devel mailing list