[FFmpeg-devel] [PATCH 6/8] lavc/libvpxenc: drop a useless condition

James Zern jzern at google.com
Tue Feb 28 23:12:18 EET 2023


On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov <anton at khirnov.net> wrote:
>
> A non-NULL packet is always passed to frame_data_apply().
> ---
>  libavcodec/libvpxenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

lgtm

> diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
> index af16e53deb..33f35bbaf4 100644
> --- a/libavcodec/libvpxenc.c
> +++ b/libavcodec/libvpxenc.c
> @@ -401,7 +401,7 @@ static int frame_data_apply(AVCodecContext *avctx, AVFifo *fifo, AVPacket *pkt)
>  {
>      FrameData fd;
>      uint8_t *data;
> -    if (!pkt || av_fifo_peek(fifo, &fd, 1, 0) < 0)
> +    if (av_fifo_peek(fifo, &fd, 1, 0) < 0)
>          return 0;
>      if (fd.pts != pkt->pts)
>          return 0;
> --
> 2.39.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list