[FFmpeg-devel] [PATCH 8/8] fftools/ffmpeg: always generate CFR output when -r is used

[Anton Khirnov]

Quoting Paul B Mahol (2023-01-04 18:37:31)
> On Wed, Jan 4, 2023 at 5:46 PM Anton Khirnov <anton at khirnov.net> wrote:
> 
> > Current code may, depending on the muxer, decide to use VSYNC_VFR tagged
> > with the specified framerate, without actually performing framerate
> > conversion. This is clearly wrong and against the documentation, which
> > states unambiguously that -r should produce CFR output for video
> > encoding.
> >
> > FATE test changes:
> > * nuv-rtjpeg: replace -r with '-enc_time_base -1', which keeps the
> >   original timebase. Output frames are now produced with proper
> >   durations.
> > * filter-mpdecimate: just drop the -r option, it is unnecessary
> > * filter-fps-r: remove, this test makes no sense and actually
> >   produces broken VFR output (with incorrect frame durations).
> >
> 
> With this patch or even before?

With current master, so without the patch.

After the patch it starts producing proper CFR, but is then redundant
with fate-filter-fps-cfr.

-- 
Anton Khirnov