[FFmpeg-devel] [PATCH 4/5] avcodec/videotoolbox: fix documents of AVVideotoolboxContext

Zhao Zhili quinkblack at foxmail.com
Mon Jan 9 14:50:07 EET 2023


From: Zhao Zhili <zhilizhao at tencent.com>

Since those fields will be overridden by videotoolbox_start(), they
should never be set by user, it can trigger memory leaks otherwise.
---
 libavcodec/videotoolbox.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavcodec/videotoolbox.h b/libavcodec/videotoolbox.h
index 3cd1d254ff..ba5eddbf46 100644
--- a/libavcodec/videotoolbox.h
+++ b/libavcodec/videotoolbox.h
@@ -57,7 +57,6 @@
 typedef struct AVVideotoolboxContext {
     /**
      * Videotoolbox decompression session object.
-     * Created and freed the caller.
      */
     VTDecompressionSessionRef session;
 
@@ -79,13 +78,11 @@ typedef struct AVVideotoolboxContext {
 
     /**
      * CoreMedia Format Description that Videotoolbox will use to create the decompression session.
-     * Set by the caller.
      */
     CMVideoFormatDescriptionRef cm_fmt_desc;
 
     /**
      * CoreMedia codec type that Videotoolbox will use to create the decompression session.
-     * Set by the caller.
      */
     int cm_codec_type;
 } AVVideotoolboxContext;
-- 
2.35.3



More information about the ffmpeg-devel mailing list