[FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern

Anton Khirnov anton at khirnov.net
Tue Jan 10 13:07:26 EET 2023


Quoting Mark Reid (2023-01-06 19:09:10)
> On Mon, Dec 26, 2022 at 1:31 PM Mark Reid <mindmark at gmail.com> wrote:
> 
> >
> >
> > On Mon, Dec 12, 2022 at 6:42 PM <mindmark at gmail.com> wrote:
> >
> >> From: Mark Reid <mindmark at gmail.com>
> >>
> >> ---
> >>  libavcodec/x86/bswapdsp.asm | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm
> >> index 31c6c48a21..2aa235e13c 100644
> >> --- a/libavcodec/x86/bswapdsp.asm
> >> +++ b/libavcodec/x86/bswapdsp.asm
> >> @@ -26,8 +26,6 @@
> >>  SECTION_RODATA
> >>  pb_bswap32: db 3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12
> >>
> >> -cextern pb_80
> >> -
> >>  SECTION .text
> >>
> >>  ; %1 = aligned/unaligned
> >> --
> >> 2.31.1.windows.1
> >>
> >>
> > ping
> >
> 
> ping

Are you really duplicating a whole bunch of files from lavc in sws? I
don't think that's anywhere remotely close to acceptable.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list