[FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

[Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics]

Hi,
It's been almost a month since we submitted our latest changes to the FFmpeg patchwork. I know that EVC implementation isn't the only thing you are working on at the moment but we'd like to do another step forward, toward merging our implementation into the master branch of the FFmpeg repository. 
The contribution is something that we take seriously so we'd like to finally do some progress.
We would like to merge it as soon as it is enough good and it meets the expected quality. Continual synchronization of our changes with the latest FFmpeg changes and splitting our changes into patches is, let's say a painstaking job. It would be much easier to develop and refine the code if we could skip that hard splitting on patches step that we have to do each time we do any, even small change.
We know that the new FFmpeg version will be released soon and you may be absorbed and overwhelmed with the work related to the new release. However, we'd be grateful if you found a little time and take a look at our latest changes.
Last but not least. Do you have any plans related to including such changes as our EVC implementation in the next release?

Regards


-----Original Message-----
From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Michael Niedermayer
Sent: czwartek, 15 grudnia 2022 20:23
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

On Thu, Dec 15, 2022 at 10:14:40AM +0100, Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics wrote:
> 
> 
> 
> 
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of 
> Michael Niedermayer
> Sent: środa, 14 grudnia 2022 22:36
> To: FFmpeg development discussions and patches 
> <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in 
> Changelog and MAINTAINERS files
> 
> On Tue, Dec 13, 2022 at 08:33:29AM -0500, Ronald S. Bultje wrote:
> > Hi David,
> > 
> > On Tue, Dec 13, 2022 at 7:22 AM Dawid Kozinski/Multimedia (PLT) 
> > /SRPOL/Staff Engineer/Samsung Electronics <d.kozinski at samsung.com> wrote:
> > 
> > > Should I leave the following lines:
> > > +  libxevd.c                             Dawid Kozinski
> > > +  libxeve.c,                            Dawid Kozinski
> > > +  evc.c, evc.h                        Dawid Kozinski
> > > +  evcdec.c                             Dawid Kozinski
> > > +  evc_parser.c                      Dawid Kozinski
> > >
> > > or should I remove them?
> > >
> > 
> > Here's a question for you, and the answer probably becomes 
> > self-evident from that. If you, Dawid, stop working for Samsung, for 
> > example because you're starting your own business or Samsung fires 
> > you or Google hires you, or if Samsung stops sponsoring this new 
> > codec called "EVC" or stops contributing to this new library 
> > "libxeve". Will you, Dawid, still maintain these files?
> > 
> > If the answer is yes, then you can shorten these lines ("evc*.[ch]: Dawid"
> > & "livxev[ed].c: Dawid") and keep them.
> > 
> > If the answer is no, then I think you should remove (or adjust) 
> > these lines, since they are (in their current form) inaccurate: you 
> > are not maintaining these files, your company is.
> > 
> 
> I think for code maintained by a company we still should list a person 
> because persons can be contacted while large companies are sometimes 
> very difficult to contact.
> maybe
> Dawid Kozinski (Samsung) or Samsung (Dawid Kozinski) or something like 
> that would specify this better
> 
> thx
> 
> Hi,
> To be clear. We are not fighting for the right to push. The write 
> access is not our goal at the moment.
> We just want to do our contribution to the FFMpeg project and provide 
> support for the EVC codec and the only reason we've added entries to 
> the MAINTENANCE file is to provide the information so others know who 
> to contact about the codec.
> 
> Yesterday I submitted new patches to the FFMepg patchwork and 
> following what Lynne said I removed our entries from the MAINTENANCE file.
> 
> However, If I understand you correctly, I shouldn't remove it, I 
> should though leave the information in the file.
> So now I should restore what I removed. 
> Correct me if I'm wrong cause it's a bit confusing.

I think the entry in some form is fine but I would suggest to leave the entry out until the discussion with Lynne reaches some consensus. And then after (we all mostly agree) add the entry That way everyone can calmly discuss this

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates