[FFmpeg-devel] [PATCH 2/4] lavfi/framesync: reorder functions to avoid a forward declaration

[Nicolas George]

Anton Khirnov (12023-01-27):
> ---
>  libavfilter/framesync.c | 144 ++++++++++++++++++++--------------------
>  1 file changed, 71 insertions(+), 73 deletions(-)

Getting rid of the forward declaration would be a good idea. But the
order you have put the functions is completely illogical. For example
you separated ff_framesync_preinit() and ff_framesync_init() with
functions that have nothing to do with initialization.

Moving framesync_advance() closer to its call point would probably be a
much better idea.

So: not like this.

-- 
  Nicolas George