[FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix segfault

Xiang, Haihao haihao.xiang at intel.com
Mon Jan 30 07:23:21 EET 2023


From: Haihao Xiang <haihao.xiang at intel.com>

This is a regression since commit fbdba9a1a69fe4df413d9e9df1b11db522946e75

input_image is freed in vaapi_encode_wait() however it is still used in
commit fbdba9a1a69fe4df413d9e9df1b11db522946e75

$ ffmpeg -vaapi_device /dev/dri/renderD128 -f lavfi -i testsrc -vf
"format=nv12,hwupload" -c:v h264_vaapi -f null -

Note input_image will be freed in vaapi_encode_free() now.

Cc: Anton Khirnov <anton at khirnov.net>
Signed-off-by: Haihao Xiang <haihao.xiang at intel.com>
---
 libavcodec/vaapi_encode.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c
index 6787b90e8d..b644814b6c 100644
--- a/libavcodec/vaapi_encode.c
+++ b/libavcodec/vaapi_encode.c
@@ -173,9 +173,6 @@ static int vaapi_encode_wait(AVCodecContext *avctx,
         }
     }
 
-    // Input is definitely finished with now.
-    av_frame_free(&pic->input_image);
-
     pic->encode_complete = 1;
     return 0;
 }
-- 
2.17.1



More information about the ffmpeg-devel mailing list