[FFmpeg-devel] [PATCH] lavfi: get rid of FF_INTERNAL_FIELDS

[Anton Khirnov]

Quoting Nicolas George (2023-01-31 15:31:44)
> Anton Khirnov (12023-01-31):
> > Do you?
> > 
> > You keep implying in your emails that you are the authority on lavfi,
> > but I see no objective support for this claim. MAINTAINERS only lists
> > you as the maintainer for graphdump.c and two filters.
> > And taken e.g. by the number of commits touching libavfilter/, mine is
> > similar to yours, and both are far behind other people.
> 
> I know the code, how it works.
> 
> I know how the code needs to evolve to achieve new features without
> breaking existing.
> 
> I review and apply patches to fix bugs when they come; fortunately it
> does not happen frequently.

I still see no objective facts supporting your claim of exclusive
maintainership over the entirety of lavfi generic code and public API.
Considering yourself the maintainer in your own head is not enough.

So to avoid any further pointless bickering, I'm hereby asking the TC to
resolve this.

To summarize my view, this patch is an improvement because:
* it prevents filterlink internals from being visible in a
  public header, where they have no business being
* it is a step towards hiding more of lavfi internals from public
  headers
* the same pattern is already and ever more widely used in the other
  libraries and ffmpeg CLI
* it is supported by Andreas (who submitted a more general analogue of
  this patch over a year ago) and Paul
* I am not aware of anyone other than Nicolas being against it

-- 
Anton Khirnov