[FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

[Tomas Härdin]

tor 2023-06-29 klockan 09:14 +0200 skrev Nicolas George:
> Tomas Härdin (12023-06-29):
> 
> >                           The reason why XML parsing shouldn't be
> > implemented in FFmpeg isn't just because it is difficult but
> > because:
> > 
> > * it is out of scope
> 
> It is necessary.

Factually incorrect. libxml2 provides what we need. libexpat would also
be acceptable. In fact providing that option may be useful to
packagers.

> > * it is technical debt
> > * shitty parsing is the cause of the vast majority of CVEs
> > 
> > It speaks of an inability to make sane architectural decisions, of
> > not
> > seperating concerns and of preferring cowboy coding over sane
> > decisions
> > with respect to the entire free software ecosystem.
> 
> Thank you for illustrating my words with your inability to consider
> that
> (1) we do not need a complete parser (2) the things that make parsing
> XML hard are precisely the things we do not need and (3) if you
> consider
> writing such a XML parser is way too hard, it speaks more of your
> skills
> in that area than anything else.

I am perfectly capable of writing an XML parser, potentially a formally
correct one. But more importantly I am capable of understanding that
doing so would be a waste of time and (if not formally verified) a
source of CVEs. The same goes for AM demodulation.

> > Are you implying that API and ABI stability are not important?
> 
> Precisely. Nothing is “important” in absolute?

ABI and API stability are Pretty Fucking Important. This attitude alone
is reason to withdraw push access.



> API and ABI stability are important if you want to be of service.

What do you think the point of this project is?


> Well, let me tell you this: if you want to force me to not have fun
> and
> spend effort on things you think are important instead, go fork
> yourself.

Childish insults do not make you right, but rather the opposite.
Discipline is important, especially in large projects.

/Tomas