[FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

[Tomas Härdin]

lör 2023-07-01 klockan 22:41 +0300 skrev Martin Storsjö:
> On Sat, 1 Jul 2023, Michael Niedermayer wrote:
> 
> > On Sat, Jul 01, 2023 at 12:36:06AM +0300, Martin Storsjö wrote:
> > > On Fri, 30 Jun 2023, Michael Niedermayer wrote:
> > > 
> > > > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote:
> > > > > If you apply this I will apply my pending libswresample
> > > > > commits and also
> > > > > remove sonic decoder from libavcodec.
> > > > 
> > > > ok, if you plan to fix the bugs in the libswresample patches
> > > > 
> > > > ill wait a bit, so others can object and if no objections will
> > > > apply the current SDR patch with the probe function disabled.
> > > > That ensures it will not be used without the user explicitly
> > > > selecting it.
> > > 
> > > I object to merging this patch.
> > > 
> > > As numerous others have said already, this is at the wrong level
> > > of
> > > abstraction, even if it happens to work for you for the current
> > > use case.
> > > 
> > > Even if it is disabled by default, git master isn't a playground
> > > for
> > > personal projects.
> > 
> > If you belive this is implemented at the wrong level,
> > can you please elaborately explain the implementation which is
> > in your oppinion at the correct level ?
> 
> As there are talks about receiving DAB/DVB from the same source,
> those 
> would definitely be on a different level than libavformat, since the 
> output of them would be an mpegts stream (or multiple), or whatever 
> transport format DAB uses.

This is a good point that hadn't occurred to me. For DAB and DVB what
you get is more akin to a protocol than a demux. But obviously
considering a stream of analog values to be a protocol (in the lavf
sense) would be stretching the concept in the extreme. The violation of
the OSI stack here becomes very visible.

/Tomas