[FFmpeg-devel] [SDR][RFC] libavradio branch changes

[Michael Niedermayer]

On Mon, Jul 03, 2023 at 10:54:05AM +0200, Paul B Mahol wrote:
> On Mon, Jul 3, 2023 at 7:48 AM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > Hi
> >
> > the new libavradio in its new repository needs some changes the problem
> > is that maintaining it in a separate repository AND seperate directory is
> > not
> > so simple
> > But let me show this in numbers, this is the stats of the changes related
> > to the build
> > system that would need to be maintained:
> >
> > commit e262fd4b85a1a3ddf34c365bb88e54cdc6be53eb
> > Author: Michael Niedermayer <michael at niedermayer.cc>
> > Date:   Sun Jul 2 14:08:42 2023 +0200
> >
> >     Move sdr to new libavradio
> >
> >     Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >
> >  Makefile                                          |   5 +--
> >  configure                                         |  36
> > ++++++++++++++++++++--
> >  fftools/ffmpeg.c                                  |   5 +++
> >  fftools/ffplay.c                                  |   4 +++
> >  fftools/ffprobe.c                                 |   4 +++
> >  fftools/opt_common.c                              |  62
> > ++++++++++++++++++++++++++++++++++---
> >  fftools/opt_common.h                              |  27 ++++++++++++++++
> >  libavdevice/Makefile                              |   1 -
> >  libavdevice/alldevices.c                          |   1 -
> >  libavdevice/utils.c                               |   2 +-
> >  libavformat/allformats.c                          |  32
> > ++++++++++++++-----
> >  libavformat/internal.h                            |   1 +
> >  libavradio/Makefile                               |  14 +++++++++
> >  libavradio/allradios.c                            |  65
> > +++++++++++++++++++++++++++++++++++++++
> >  libavradio/avradio.c                              |  32
> > +++++++++++++++++++
> >  libavradio/avradio.h                              | 121
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  libavradio/internal.h                             |  28 +++++++++++++++++
> >  libavdevice/sdrindev.c => libavradio/sdrinradio.c |   2 +-
> >  {libavdevice => libavradio}/utils.c               |   4 +--
> >  libavradio/version.c                              |  45
> > +++++++++++++++++++++++++++
> >  libavradio/version.h                              |  45
> > +++++++++++++++++++++++++++
> >  libavradio/version_major.h                        |  36
> > ++++++++++++++++++++++
> >  libavutil/log.h                                   |   1 +
> >  tools/uncoded_frame.c                             |   4 +++
> >  24 files changed, 554 insertions(+), 23 deletions(-)
> >
> >
> >
> > I do not know if changes to the build system can be marged in git master or
> > if people agree to that at all.
> > But if this needs to be maintained in its current form, it will cause bugs
> > and alot of extra work over time
> >
> > the alternative would be to undo the libavradio thing and rather maintain
> > sdr as input device and demuxer in the libavradio repository
> >


> > Of course having the sdr input device and file demuxer in git master would
> > be the least amount of work
> >
> 
> Everyone is against this, pushing for it will not make it happen.

I think there where about 6 people who had varing levels of dislike to it.
Probably a few more. Thats not everyone

But i have not suggested that to be done now, i have not pushed for that at
all in the text or mail above.
Its just a statement of fact that it would be least work.
That statement, that its least work, has not been disputed by anyone

I mentioned this so people dont miss that the way its done now, has a
cost to it. The 2 repository approuch costs additional time to maintain

Also moving the whole libavradio to git master is not what this mail was
intended to suggest at all.

Thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230703/bdcbaedd/attachment.sig>