[FFmpeg-devel] [PATCH 1/3] avcodec/decode: move processing discard samples to its own function

Anton Khirnov anton at khirnov.net
Sun Jul 9 15:15:11 EEST 2023


Quoting James Almer (2023-07-09 14:11:14)
> 
> I could call it discard_samples_or_frame(), or discard_frame().
> If i process the video in the caller, it will end up being duplicated in 
> patch 2, which goes against the point of factoring this out.

The duplicated code would be 2 very simple lines. The cost you're paying
for avoiding the duplication seems worse to me.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list