[FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

Carotti, Elias eliascrt at amazon.it
Mon Jul 10 15:51:25 EEST 2023


On Mon, 2023-07-10 at 08:13 +0000, Carotti, Elias wrote:
> 

> AVVideoHint is a bad name for something like this.
> Could you borrow some wording from graphics and call it
> AVVideoDamagedHint or maybe AVVideoChangedAreaHint or a combination
> of both?
> I'd prefer the former, damage is standard language in graphics
> circles about what has changed since the last frame.
> 
> Hi,
> I have no strong objections on this. Personally I also like the
> AVVideoDamagedHint name best, my only concern is that it is strictly
> related to the current use/implementation 
> (it's true right now that's the only kind of hint) while it may turn
> out to be a bad naming decision should other forms of hinting for the
> encoder be added in the future.
> That said, I am fine with the change too.
> Elias
> 

I added a type to the AVVideoRect struct. This should solve the naming
issue above while preserving the possibility to extend this to
different hinting types.
These are the only changes to Anton's version.
Best
Elias

 





NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-side-data-type-to-provide-hint-to-the-video-enco.patch
Type: text/x-patch
Size: 10027 bytes
Desc: 0001-Add-side-data-type-to-provide-hint-to-the-video-enco.patch
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230710/45a9220f/attachment.bin>


More information about the ffmpeg-devel mailing list