[FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical

[Rémi Denis-Courmont]

Le sunnuntaina 9. heinäkuuta 2023, 0.41.35 EEST Michael Niedermayer a écrit :
> On Fri, Jul 07, 2023 at 10:05:39PM +0800, Nuo Mi wrote:
> > This is the main entry point for the CTU (Coding Tree Unit) decoder.
> > The code will divide the CTU decoder into several stages.
> > It will check the stage dependencies and run the stage decoder.
> > ---
> > 
> >  libavcodec/vvc/Makefile     |   3 +-
> >  libavcodec/vvc/vvc_thread.c | 804 ++++++++++++++++++++++++++++++++++++
> >  libavcodec/vvc/vvc_thread.h |  73 ++++
> >  3 files changed, 879 insertions(+), 1 deletion(-)
> >  create mode 100644 libavcodec/vvc/vvc_thread.c
> >  create mode 100644 libavcodec/vvc/vvc_thread.h
> 
> seems not to build with enable-shared
> 
> src/libavcodec/vvc/vvc_thread.c:235:9: error: address argument to atomic
> operation must be a pointer to non-const _Atomic type ('const atomic_int *'
> (aka 'const _Atomic(int) *') invalid) if (atomic_load(&ft->ret))
>         ^           ~~~~~~~~

That is a known bug in the Clang compiler that was fixed in newer versions, 
AFAIK. You seem to be using something ancient...

> /usr/lib/llvm-6.0/lib/clang/6.0.0/include/stdatomic.h:134:29: note: expanded
> from macro 'atomic_load' #define atomic_load(object)
> __c11_atomic_load(object, __ATOMIC_SEQ_CST) ^                 ~~~~~~
> 1 error generated.
> src/ffbuild/common.mak:81: recipe for target 'libavcodec/vvc/vvc_thread.o'
> failed make: *** [libavcodec/vvc/vvc_thread.o] Error 1
> make: *** Waiting for unfinished jobs....
> 
> 
> [...]


-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/