[FFmpeg-devel] [PATCH 1/2] avcodec/decode: don't reject flush packets when buffer_pkt is not empty

Anton Khirnov anton at khirnov.net
Wed Jul 12 16:28:03 EEST 2023


Quoting James Almer (2023-07-12 13:30:30)
> On 7/12/2023 6:06 AM, Anton Khirnov wrote:
> > Quoting James Almer (2023-07-12 04:06:43)
> >> Restores the behavior pre commit a92dbeb9ae.
> >>
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> > 
> > Do you see any advantage to this?
> 
> Not returning an error when a flush packet is feed to the decoder. Why 
> would the API force me to retrieve frames before i can tell it I'm not 
> going to feed it any more packets?

Right, I guess that makes sense.
We should document this behaviour explicitly though, if we're bothering
to maintain it.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list