[FFmpeg-devel] [PATCH 01/33] fftools/ffmpeg_mux_init: return errors from of_open() instead of aborting

Anton Khirnov anton at khirnov.net
Thu Jul 13 16:01:13 EEST 2023


Quoting zhilizhao(赵志立) (2023-07-13 14:01:48)
> 
> 
> > On Jul 13, 2023, at 18:55, Anton Khirnov <anton at khirnov.net> wrote:
> > 
> > ---
> > fftools/ffmpeg_mux_init.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> > index 6ab541d7c5..8a3e7b98cf 100644
> > --- a/fftools/ffmpeg_mux_init.c
> > +++ b/fftools/ffmpeg_mux_init.c
> > @@ -2380,7 +2380,7 @@ int of_open(const OptionsContext *o, const char *filename)
> >         int64_t start_time = o->start_time == AV_NOPTS_VALUE ? 0 : o->start_time;
> >         if (stop_time <= start_time) {
> >             av_log(mux, AV_LOG_ERROR, "-to value smaller than -ss; aborting.\n");
> > -            exit_program(1);
> > +            return AVERROR(EINVAL);
> 
> The log message still says ‘aborting’.

>From the user's POV it does abort the transcoding, so the message is IMO
still accurate. The change is only in how precisely the abort is done.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list