[FFmpeg-devel] [PATCH 16/33] fftools/ffmpeg_mux_init: improve of_add_programs()

[Anton Khirnov]

Quoting Michael Niedermayer (2023-07-14 01:30:24)
> On Thu, Jul 13, 2023 at 12:55:36PM +0200, Anton Khirnov wrote:
> > Replace duplicated(!) and broken* custom string parsing with
> > av_dict_parse_string(). Return error codes instead of aborting.
> > 
> > * e.g. it treats NULL returned from av_get_token() as "separator not
> >   found", when in fact av_get_token() only returns NULL on memory
> >   allocation failure
> > ---
> >  fftools/ffmpeg_mux_init.c | 111 ++++++++++++++++++--------------------
> >  1 file changed, 52 insertions(+), 59 deletions(-)
> 
> smells like memory corruption
> 
> -i ~/videos/01c56b0dc1.ts -copy_unknown -map 0 -c copy -fflags +bitexact  -t 3 -y file-copy-unknown.ts

I have no idea why are you replying to this specific patch, when this
issue apparently exists in current master.

I'll send a fix for it in a later patchset, but it's completely
unrelated to this set.

-- 
Anton Khirnov