[FFmpeg-devel] [PATCH 2/2] aarch64: remove VFP feature check

Martin Storsjö martin at martin.st
Fri Jul 14 21:18:54 EEST 2023


On Fri, 14 Jul 2023, Rémi Denis-Courmont wrote:

> This is not actually used for anything. The configure check causes the
> CPU feature flag to be set, but nothing consumes it at all.
>
> While AArch64 does have VFP, it is only used for the scalar C code.
> Conversely, it is still possible to disable VFP, by changing the
> C compiler flags as before (though that only makes sense for an
> hypothetical non-standard Armv8 platform without VFP).
>
> Note that this retains the "vfp" option flag, for backward
> compatibility and on the very remote but theoretically possible chance
> that FFmpeg actually makes use of it in the future.
>
> AV_CPU_FLAG_VFP is retained as it is actually used by AArch32.
> ---
> configure               | 4 +---
> libavutil/aarch64/cpu.c | 3 +--
> 2 files changed, 2 insertions(+), 5 deletions(-)

LGTM for both patches.

// Martin


More information about the ffmpeg-devel mailing list