[FFmpeg-devel] [PATCH] hevcdsp_idct_neon.S: Avoid unnecessary mov.

[Martin Storsjö]

On Wed, 26 Jul 2023, Reimar.Doeffinger at gmx.de wrote:

> From: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
>
> ret can be given an argument instead.
> This is also consistent with how other assembler code
> in FFmpeg does it.
> ---
> libavcodec/aarch64/hevcdsp_idct_neon.S | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/aarch64/hevcdsp_idct_neon.S b/libavcodec/aarch64/hevcdsp_idct_neon.S
> index b7f23386a4..f7142c939c 100644
> --- a/libavcodec/aarch64/hevcdsp_idct_neon.S
> +++ b/libavcodec/aarch64/hevcdsp_idct_neon.S
> @@ -617,8 +617,7 @@ function ff_hevc_idct_16x16_\bitdepth\()_neon, export=1
>
>         add              sp,  sp,  #640
> 
> -        mov             x30, x15
> -        ret
> +        ret             x15
> endfunc
> .endm
> 
> @@ -814,8 +813,7 @@ function ff_hevc_idct_32x32_\bitdepth\()_neon, export=1
> .endr
>
>         add             sp,  sp,  #2432
> -        mov             x30, x15
> -        ret
> +        ret             x15
> endfunc
> .endm

LGTM, assuming checkasm still passes.

// Martin