[FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API

[Anton Khirnov]

Quoting Marton Balint (2023-05-30 23:09:50)
> 
> 
> On Fri, 20 Jan 2023, Anton Khirnov wrote:
> 
> > ---
> > libavfilter/graphparser.c | 537 +++++++++-----------------------------
> > 1 file changed, 126 insertions(+), 411 deletions(-)
> 
> This change makes error messages for parse failures less useful or 
> completely missing. E.g.:
> 
> ffmpeg -f lavfi -i testsrc -vf yadif,scale=dummy=boo -f null none
> 
> Before:
> 
> [Parsed_scale_0 @ 0x555c19335b00] Option 'dummy' not found
> [AVFilterGraph @ 0x555c19333e00] Error initializing filter 'scale' with args 'dummy=boo:flags=bicubic'
> Error reinitializing filters!
> 
> After:
> 
> [AVFilterGraph @ 0x3c5a100] Error applying filter options
> Error reinitializing filters!

Cannot reproduce, for me current git master says:
Input #0, lavfi, from 'testsrc':
  Duration: N/A, start: 0.000000, bitrate: N/A
  Stream #0:0: Video: wrapped_avframe, rgb24, 320x240 [SAR 1:1 DAR 4:3], 25 fps, 25 tbr, 25 tbn
Error applying option 'dummy' to filter 'scale': Option not found
Option not found

Which could be improved, but it does mention the unknown option name.
> ffplay -f lavfi -i testsrc -vf yadif,scale=dummy=boo
> 
> Before:
> 
> [Parsed_scale_1 @ 0x55fa2b935080] Option 'dummy' not found
> Error initializing filter 'scale' with args 'dummy=boo:flags=bicubic'
> 
> After:
> 
> (no error message)

Should be addressed by the patch I just sent.

-- 
Anton Khirnov