[FFmpeg-devel] [PATCH] pthread_frame: uninit the hwaccel of each frame thread

Lynne dev at lynne.ee
Thu Jun 15 23:03:20 EEST 2023


Jun 15, 2023, 20:26 by anton at khirnov.net:

> Quoting Lynne (2023-06-13 04:11:35)
>
>> The issue is that with a threadsafe hwaccel and multiple enabled
>> frame threads, hwaccel->uninit() is never called.
>> Previously, the function was guaranteed to never have any threads
>> with hwaccel contexts, so it never bothered to uninit it.
>>
>> Patch attached.
>>
>
> Maybe add a note that this only does something for threadsafe hwaccels,
> since otherwise hwaccel state is always cleared here.
>
> Otherwise looks good assuming it was tested with a leak checker.
>

A leak checker is how I actually found this :)
Thanks, added a note and pushed.


More information about the ffmpeg-devel mailing list