[FFmpeg-devel] [PATCH v2] avformat/http: copy only mime type from Content-Type

Kacper Michajlow kasper93 at gmail.com
Fri Jun 16 20:46:59 EEST 2023


On Thu, 1 Jun 2023 at 21:44, Kacper Michajłow <kasper93 at gmail.com> wrote:
>
> Content-Type can include charset and boundary which is not a part of
> mime type and shouldn't be copied as such.
>
> Fixes HLS playback when the Content-Type includes additional fields.
>
> Signed-off-by: Kacper Michajłow <kasper93 at gmail.com>
> ---
>  libavformat/http.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/http.c b/libavformat/http.c
> index 0817aafb5b..fd931c2d8e 100644
> --- a/libavformat/http.c
> +++ b/libavformat/http.c
> @@ -1205,7 +1205,7 @@ static int process_line(URLContext *h, char *line, int line_count)
>              }
>          } else if (!av_strcasecmp(tag, "Content-Type")) {
>              av_free(s->mime_type);
> -            s->mime_type = av_strdup(p);
> +            s->mime_type = av_get_token((const char **)&p, ";");
>          } else if (!av_strcasecmp(tag, "Set-Cookie")) {
>              if (parse_cookie(s, p, &s->cookie_dict))
>                  av_log(h, AV_LOG_WARNING, "Unable to parse '%s'\n", p);
> --
> 2.34.1
>

Bump. I would prefer this smal thing to be fixed upstream, than adding
workaround.

Thanks.


More information about the ffmpeg-devel mailing list