[FFmpeg-devel] [PATCH 16/21] fftools/ffmpeg_dec: move decoding to a separate thread

Anton Khirnov anton at khirnov.net
Sat Jun 17 05:55:05 EEST 2023


Quoting Michael Niedermayer (2023-06-16 22:58:21)
> On Wed, Jun 14, 2023 at 06:49:03PM +0200, Anton Khirnov wrote:
> > This is only a preparatory step to a fully threaded architecture and
> > does not yet make decoding truly parallel - the main thread will
> > currently submit a packet and wait until it has been fully processed by
> > the decoding thread before moving on. Decoded behavior as observed by
> > the rest of the program should remain unchanged. That will change in
> > future commits after encoders and filters are moved to threads and a
> > thread-aware scheduler is added.
> > ---
> >  fftools/ffmpeg.c     |  63 +++++---
> >  fftools/ffmpeg.h     |  11 ++
> >  fftools/ffmpeg_dec.c | 365 ++++++++++++++++++++++++++++++++++++++-----
> >  fftools/ffmpeg_mux.c |   5 -
> >  4 files changed, 382 insertions(+), 62 deletions(-)
> 
> This seems to break (infinite loop)
> 
> ffmpeg -i videos/bink/thps4/ACDC.smo -bitexact -t 1 -y ACDC.smo.avi
> 
> file seems there: on samples server: game-formats/bink/thps4/ACDC.smo

This is a bug in the binkaudio decoder, fixed by the patch I just sent.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list