[FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors

[Paul B Mahol]

On Sat, Jun 17, 2023 at 9:47 AM Anton Khirnov <anton at khirnov.net> wrote:

> Quoting Paul B Mahol (2023-06-17 09:39:24)
> > On Sat, Jun 17, 2023 at 9:16 AM Anton Khirnov <anton at khirnov.net> wrote:
> >
> > > Quoting Paul B Mahol (2023-06-17 08:35:21)
> > > > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov <anton at khirnov.net>
> wrote:
> > > >
> > > > > Make sure we don't repeatedly try to decode the same packet,
> making no
> > > > > progress and possibly causing an infinite loop.
> > > > >
> > > >
> > > > Doesn't all error paths, bellow goto label in function, needs this
> (reset
> > > > of ch_offset to 0 and unref of pkt) ?
> > >
> > > I see no other error paths in that function, beside handling the
> failure
> > > of ff_decode_get_packet().
> > >
> > >
> > get_buffer?
>
> I am adding goto fail for the get_buffer() call in this patch, so I
> don't understand what your concern is.
>

Yes, patch ok.


>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>