[FFmpeg-devel] [RFC] [PATCH 1/5] hwcontext: add a new AVHWFramesContext.opaque field

Lynne dev at lynne.ee
Sun Jun 18 13:58:32 EEST 2023


Jun 16, 2023, 13:02 by dev at lynne.ee:

> Jun 13, 2023, 19:18 by dev at lynne.ee:
>
>> Jun 13, 2023, 18:56 by andreas.rheinhardt at outlook.com:
>>
>>> Lynne:
>>>
>>>> +    dst->opaque    = av_buffer_ref(src->opaque);
>>>> +    if (!dst->opaque) {
>>>> +        ret = AVERROR(ENOMEM);
>>>> +        goto fail;
>>>> +    }
>>>>
>>>
>>> According to the doxy, opaque can be left unset (and will be given that
>>> it is a new field), yet av_buffer_ref(NULL) will crash. We have
>>> av_buffer_replace() for something like that.
>>>
>>
>> Fixed.
>>
>
> Ping.
>

Consider this out of RFC state.


More information about the ffmpeg-devel mailing list