[FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content

[James Almer]

On 6/18/2023 11:27 PM, Wang Bin wrote:
> - Changes in mov_write_video_tag function to handle EVC elementary stream
>> - Provided structure EVCDecoderConfigurationRecord that specifies the
>> decoder configuration information for ISO/IEC 23094-1 video content
>>
>> Signed-off-by: Dawid Kozinski <d.kozinski at samsung.com>
>> ---
>>   libavformat/Makefile    |   2 +-
>>   libavformat/evc.c       | 422 ++++++++++++++++++++++++++++++++++++++++
>>   libavformat/evc.h       |  44 +++++
>>   libavformat/isom_tags.c |   2 +
>>   libavformat/movenc.c    |  33 ++++
>>   5 files changed, 502 insertions(+), 1 deletion(-)
>>   create mode 100644 libavformat/evc.c
>>   create mode 100644 libavformat/evc.h
>>
>> diff --git a/libavformat/Makefile b/libavformat/Makefile
>> index 6e4231fda2..d3503196e3 100644
>> --- a/libavformat/Makefile
>> +++ b/libavformat/Makefile
>> @@ -364,7 +364,7 @@ OBJS-$(CONFIG_MOV_DEMUXER)               += mov.o
>> mov_chan.o mov_esds.o \
>>   OBJS-$(CONFIG_MOV_MUXER)                 += movenc.o av1.o avc.o hevc.o
>> vpcc.o \
>>                                               movenchint.o mov_chan.o rtp.o
>> \
>>                                               movenccenc.o movenc_ttml.o
>> rawutils.o \
>> -                                            dovi_isom.o
>> +                                            dovi_isom.o evc.o
>>   OBJS-$(CONFIG_MP2_MUXER)                 += rawenc.o
>>   OBJS-$(CONFIG_MP3_DEMUXER)               += mp3dec.o replaygain.o
>>   OBJS-$(CONFIG_MP3_MUXER)                 += mp3enc.o rawenc.o id3v2enc.o
>>
> 
> This breaks msvc build. golomb_tab.o is required in
> OBJS-$(CONFIG_MOV_MUXER). otherwise i get this error
> 
> 2023-06-18T12:48:08.5213414Z LD	libavformat/avformat-60.dll
> 2023-06-18T12:48:08.6503045Z LINK : warning LNK4044: unrecognized
> option '/-icf=safe'; ignored
> 2023-06-18T12:48:08.8081443Z    Creating library
> libavformat/avformat.lib and object libavformat/avformat.exp
> 2023-06-18T12:48:08.8219530Z evc.o : error LNK2001: unresolved
> external symbol ff_golomb_vlc_len
> 2023-06-18T12:48:08.8267361Z evc.o : error LNK2001: unresolved
> external symbol ff_ue_golomb_vlc_code
> 2023-06-18T12:48:09.0122434Z libavformat\avformat-60.dll : fatal error
> LNK1120: 2 unresolved externals
> 2023-06-18T12:48:09.0517997Z make: ***
> [/d/a/avbuild/avbuild/ffmpeg-***/ffbuild/library.mak:119:
> libavformat/avformat-60.dll] Error 96
> 
> 
> full build log:
> https://github.com/wang-bin/avbuild/actions/runs/5303646918/jobs/9599433665

Should be fixed.