[FFmpeg-devel] [PATCH 1/5] avcodec/evc_frame_merge: ensure the assembled buffer fits in an AVPacket
James Almer
jamrial at gmail.com
Thu Jun 22 22:29:14 EEST 2023
Signed-off-by: James Almer <jamrial at gmail.com>
---
libavcodec/evc_frame_merge_bsf.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavcodec/evc_frame_merge_bsf.c b/libavcodec/evc_frame_merge_bsf.c
index 121f93c0b0..3e1258c6c9 100644
--- a/libavcodec/evc_frame_merge_bsf.c
+++ b/libavcodec/evc_frame_merge_bsf.c
@@ -199,8 +199,16 @@ static int evc_frame_merge_filter(AVBSFContext *bsf, AVPacket *out)
au_end_found = err;
nalu_size += EVC_NALU_LENGTH_PREFIX_SIZE;
+
+ data_size = ctx->au_buffer.data_size + nalu_size;
+ if (data_size > INT_MAX - AV_INPUT_BUFFER_PADDING_SIZE) {
+ av_log(bsf, AV_LOG_ERROR, "Assembled packet is too big\n");
+ err = AVERROR(ERANGE);
+ goto end;
+ }
+
buffer = av_fast_realloc(ctx->au_buffer.data, &ctx->au_buffer.capacity,
- ctx->au_buffer.data_size + nalu_size);
+ data_size);
if (!buffer) {
av_freep(&ctx->au_buffer.data);
err = AVERROR_INVALIDDATA;
@@ -210,7 +218,7 @@ static int evc_frame_merge_filter(AVBSFContext *bsf, AVPacket *out)
ctx->au_buffer.data = buffer;
memcpy(ctx->au_buffer.data + ctx->au_buffer.data_size, in->data, nalu_size);
- ctx->au_buffer.data_size += nalu_size;
+ ctx->au_buffer.data_size = data_size;
in->data += nalu_size;
in->size -= nalu_size;
--
2.41.0
More information about the ffmpeg-devel
mailing list