[FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

James Almer jamrial at gmail.com
Thu Jun 29 21:19:44 EEST 2023


On 6/29/2023 3:19 PM, Andreas Rheinhardt wrote:
> The discrepancy between the definition and the declaration
> in allfilters.c is actually UB.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>   libavfilter/vf_ccrepack.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_ccrepack.c b/libavfilter/vf_ccrepack.c
> index 61eb2128ae..950bb7b528 100644
> --- a/libavfilter/vf_ccrepack.c
> +++ b/libavfilter/vf_ccrepack.c
> @@ -92,7 +92,7 @@ static const AVFilterPad avfilter_vf_ccrepack_outputs[] = {
>       },
>   };
>   
> -AVFilter ff_vf_ccrepack = {
> +const AVFilter ff_vf_ccrepack = {
>       .name        = "ccrepack",
>       .description = NULL_IF_CONFIG_SMALL("Repack CEA-708 closed caption metadata"),
>       .uninit      = uninit,

LGTM


More information about the ffmpeg-devel mailing list