[FFmpeg-devel] [PATCH] lavfi/buffersrc: issue more specific error in case of invalid parameters
Anton Khirnov
anton at khirnov.net
Wed Mar 1 16:34:45 EET 2023
Quoting Stefano Sabatini (2023-03-01 01:01:26)
> ---
> libavfilter/buffersrc.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c
> index ba17450b93..ea9556d691 100644
> --- a/libavfilter/buffersrc.c
> +++ b/libavfilter/buffersrc.c
> @@ -273,9 +273,16 @@ static av_cold int init_video(AVFilterContext *ctx)
> {
> BufferSourceContext *c = ctx->priv;
>
> - if (c->pix_fmt == AV_PIX_FMT_NONE || !c->w || !c->h ||
> - av_q2d(c->time_base) <= 0) {
> - av_log(ctx, AV_LOG_ERROR, "Invalid parameters provided.\n");
> + if (c->pix_fmt == AV_PIX_FMT_NONE) {
> + av_log(ctx, AV_LOG_ERROR, "Unspecified pixel format\n");
> + return AVERROR(EINVAL);
> + }
> + if (!c->w || !c->h) {
> + av_log(ctx, AV_LOG_ERROR, "Invalid null size %dx%d\n", c->w, c->h);
^^^^
I don't know what a null size is, just drop the word.
Otherwise looks good.
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list