[FFmpeg-devel] [PATCH v4] avformat: Add support for embedding cover art in Ogg files

[Michael Niedermayer]

On Sun, Mar 05, 2023 at 03:59:41PM +0000, Zsolt Vadász wrote:
> This version can actually be applied to master. Also added checks to
> ensure there won't be an OGGStreamContext for the cover art to suppress
> warnings in mpv.
> 
> Signed-off-by: Zsolt Vadasz <zsolt_vadasz at protonmail.com>
> ---
>  libavformat/flac_picture.c | 132 ++++++++++++++++++++++
>  libavformat/flac_picture.h |   5 +
>  libavformat/flacenc.c      |  90 +--------------
>  libavformat/oggenc.c       | 217 ++++++++++++++++++++++++++++++-------
>  4 files changed, 319 insertions(+), 125 deletions(-)

breaks fate

--- ./tests/ref/lavf-fate/vp8.ogg	2023-02-25 23:39:59.312106371 +0100
+++ tests/data/fate/lavf-fate-vp8.ogg	2023-03-05 20:25:46.872310586 +0100
@@ -1,3 +1,3 @@
-20f1e9b1714513a0ba85ca636e818784 *tests/data/lavf-fate/lavf.vp8.ogg
-95009 tests/data/lavf-fate/lavf.vp8.ogg
-tests/data/lavf-fate/lavf.vp8.ogg CRC=0xa5857a66
+b6755b4eb67bac91a775e0fcc8323e49 *tests/data/lavf-fate/lavf.vp8.ogg
+76738 tests/data/lavf-fate/lavf.vp8.ogg
+tests/data/lavf-fate/lavf.vp8.ogg CRC=0xe090528e
TEST    checkasm-fmtconvert
Test lavf-fate-vp8.ogg failed. Look at tests/data/fate/lavf-fate-vp8.ogg.err for details.
tests/Makefile:306: recipe for target 'fate-lavf-fate-vp8.ogg' failed
make: *** [fate-lavf-fate-vp8.ogg] Error 1
make: *** Waiting for unfinished jobs....


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230305/04ef2286/attachment.sig>