[FFmpeg-devel] [PATCH v3 3/5] avformat/mov: parse ISO-14496-12 ChannelLayout

Tomas Härdin git at haerdin.se
Mon Mar 6 14:26:49 EET 2023


> +int ff_mov_get_channel_config_from_layout(const AVChannelLayout
> *layout, int *config)
> +{
> +    // Set default value which means any setup in 23001-8
> +    *config = 0;
> +    for (int i = 0; i < FF_ARRAY_ELEMS(iso_channel_configuration);
> i++) {
> +        if (!av_channel_layout_compare(layout,
> iso_channel_configuration + i)) {
> +            *config = i;
> +            break;
> +        }
> +    }
> +
> +    return 0;

Is always returning 0 intended? If so then what is the point?
ff_mov_get_channel_positions_from_layout() returns non-zero on error..

/Tomas



More information about the ffmpeg-devel mailing list