[FFmpeg-devel] [PATCH v3 4/5] avformat/movenc: add PCM in mp4 support

[Tomas Härdin]

tis 2023-03-07 klockan 10:30 +0800 skrev zhilizhao(赵志立):
> 
> 
> > On Mar 6, 2023, at 20:28, Tomas Härdin <git at haerdin.se> wrote:
> > 
> > > +static int mov_write_chnl_tag(AVFormatContext *s, AVIOContext
> > > *pb,
> > > MOVTrack *track)
> > > +{
> > > +    int64_t pos = avio_tell(pb);
> > > +    int config = 0;
> > > +    int ret;
> > > +    uint8_t *speaker_pos = NULL;
> > > +    const AVChannelLayout *layout = &track->par->ch_layout;
> > > +
> > > +    ret = ff_mov_get_channel_config_from_layout(layout,
> > > &config);
> > > +    if (ret || !config) {
> > 
> > ret is always 0..
> 
> That implementation details. It’s robust for caller to not depending
> on that.

Fair enough

/Tomas