[FFmpeg-devel] [PATCH 2/3] checkasm: add test for bwdif

[Thomas Mundt]

Hi James,

Am Mo., 20. Feb. 2023 um 20:59 Uhr schrieb James Darnley <jdarnley at obe.tv>:

> ---
>  tests/checkasm/Makefile   |  1 +
>  tests/checkasm/checkasm.c |  3 ++
>  tests/checkasm/checkasm.h |  1 +
>  tests/checkasm/vf_bwdif.c | 70 +++++++++++++++++++++++++++++++++++++++
>  tests/fate/checkasm.mak   |  1 +
>  5 files changed, 76 insertions(+)
>  create mode 100644 tests/checkasm/vf_bwdif.c
>
> diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile
> index a6f06c7007..b6a43f181f 100644
> --- a/tests/checkasm/Makefile
> +++ b/tests/checkasm/Makefile
> @@ -40,6 +40,7 @@ CHECKASMOBJS-$(CONFIG_AVCODEC)          +=
> $(AVCODECOBJS-yes)
>  # libavfilter tests
>  AVFILTEROBJS-$(CONFIG_AFIR_FILTER) += af_afir.o
>  AVFILTEROBJS-$(CONFIG_BLEND_FILTER) += vf_blend.o
> +AVFILTEROBJS-$(CONFIG_BWDIF_FILTER)      += vf_bwdif.o
>  AVFILTEROBJS-$(CONFIG_COLORSPACE_FILTER) += vf_colorspace.o
>  AVFILTEROBJS-$(CONFIG_EQ_FILTER)         += vf_eq.o
>  AVFILTEROBJS-$(CONFIG_GBLUR_FILTER)      += vf_gblur.o
> diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
> index e96d84a7da..5e729cf0e0 100644
> --- a/tests/checkasm/checkasm.c
> +++ b/tests/checkasm/checkasm.c
> @@ -179,6 +179,9 @@ static const struct {
>      #if CONFIG_BLEND_FILTER
>          { "vf_blend", checkasm_check_blend },
>      #endif
> +    #if CONFIG_BWDIF_FILTER
> +        { "vf_bwdif", checkasm_check_vf_bwdif },
> +    #endif
>      #if CONFIG_COLORSPACE_FILTER
>          { "vf_colorspace", checkasm_check_colorspace },
>      #endif
> diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h
> index 8744a81218..e9e73c6fa0 100644
> --- a/tests/checkasm/checkasm.h
> +++ b/tests/checkasm/checkasm.h
> @@ -82,6 +82,7 @@ void checkasm_check_utvideodsp(void);
>  void checkasm_check_v210dec(void);
>  void checkasm_check_v210enc(void);
>  void checkasm_check_vc1dsp(void);
> +void checkasm_check_vf_bwdif(void);
>  void checkasm_check_vf_eq(void);
>  void checkasm_check_vf_gblur(void);
>  void checkasm_check_vf_hflip(void);
> diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c
> new file mode 100644
> index 0000000000..e27f9b7494
> --- /dev/null
> +++ b/tests/checkasm/vf_bwdif.c
> @@ -0,0 +1,70 @@
> +/*
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with FFmpeg; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + */
> +
> +#include <string.h>
> +#include "checkasm.h"
> +#include "libavcodec/internal.h"
> +#include "libavfilter/bwdif.h"
> +
> +#define WIDTH 256
> +
> +#define randomize_buffers(buf0, buf1, mask, count) \
> +    for (size_t i; i < count; i++) \
> +        buf0[i] = buf1[i] = rnd() & mask
> +
> +void checkasm_check_vf_bwdif(void)
> +{
> +    BWDIFContext ctx_8, ctx_10, ctx_16;
> +
> +    ff_bwdif_init_filter_line(&ctx_8, 8);
> +    ff_bwdif_init_filter_line(&ctx_10, 10);
> +    ff_bwdif_init_filter_line(&ctx_16, 16);
> +
> +    if (check_func(ctx_8.filter_line, "bwdif8")) {
> +        uint8_t prev0[9*WIDTH], prev1[9*WIDTH];
> +        uint8_t next0[9*WIDTH], next1[9*WIDTH];
> +        uint8_t cur0[9*WIDTH], cur1[9*WIDTH];
> +        uint8_t dst0[WIDTH], dst1[WIDTH];
> +
> +        declare_func(void, void *dst, void *prev, void *cur, void *next,
> +                        int w, int prefs, int mrefs, int prefs2, int
> mrefs2,
> +                        int prefs3, int mrefs3, int prefs4, int mrefs4,
> +                        int parity, int clip_max);
> +
> +        randomize_buffers(prev0, prev1, 0xff, 9*WIDTH);
> +        randomize_buffers(next0, next1, 0xff, 9*WIDTH);
> +        randomize_buffers(cur0, cur1, 0xff, 9*WIDTH);
> +
> +        call_ref(dst0, prev0 + 4*WIDTH, cur0 + 4*WIDTH, next0 + 4*WIDTH,
> WIDTH,
> +                WIDTH, -WIDTH, 2*WIDTH, -2*WIDTH, 3*WIDTH, -3*WIDTH,
> 4*WIDTH, -4*WIDTH,
> +                0, 0xff);
> +        call_new(dst1, prev1 + 4*WIDTH, cur1 + 4*WIDTH, next1 + 4*WIDTH,
> WIDTH,
> +                WIDTH, -WIDTH, 2*WIDTH, -2*WIDTH, 3*WIDTH, -3*WIDTH,
> 4*WIDTH, -4*WIDTH,
> +                0, 0xff);
> +
> +        if (memcmp(dst0, dst1, WIDTH)
> +                || memcmp(prev0, prev1, sizeof prev0)
> +                || memcmp(next0, next1, sizeof next0)
> +                || memcmp(cur0, cur1, sizeof cur0))
> +            fail();
> +        bench_new(dst1, prev1 + 4*WIDTH, cur1 + 4*WIDTH, next1 + 4*WIDTH,
> WIDTH,
> +                WIDTH, -WIDTH, 2*WIDTH, -2*WIDTH, 3*WIDTH, -3*WIDTH,
> 4*WIDTH, -4*WIDTH,
> +                0, 0xff);
> +    }
> +    report("bwdif8");
> +}
>

I'm not familiar with checkasm tests, but isn't this one limited to a bit
depth of 8?


> diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak
> index a4e95541f5..6a7d4a1226 100644
> --- a/tests/fate/checkasm.mak
> +++ b/tests/fate/checkasm.mak
> @@ -37,6 +37,7 @@ FATE_CHECKASM = fate-checkasm-aacpsdsp
>                 \
>                  fate-checkasm-v210enc                                   \
>                  fate-checkasm-vc1dsp                                    \
>                  fate-checkasm-vf_blend                                  \
> +                fate-checkasm-vf_bwdif                                  \
>                  fate-checkasm-vf_colorspace                             \
>                  fate-checkasm-vf_eq                                     \
>                  fate-checkasm-vf_gblur                                  \
> --
> 2.39.1
>

Best Regards,
Thomas