[FFmpeg-devel] [PATCH v5 2/2] avutil: add HDR10+ dynamic metadata serialization function

[James Almer]

On 3/13/2023 6:39 PM, Raphaël Zumer wrote:
> Co-authored-by: Mohammad Izadi <moh.izadi at gmail.com>
> Signed-off-by: Raphaël Zumer <rzumer at tebako.net>
> ---
>   doc/APIchanges                   |   5 ++
>   libavutil/hdr_dynamic_metadata.c | 145 +++++++++++++++++++++++++++++++
>   libavutil/hdr_dynamic_metadata.h |  13 +++
>   libavutil/version.h              |   2 +-
>   4 files changed, 164 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 14737223cb..3a61d61931 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -2,6 +2,11 @@ The last version increases of all libraries were on 2023-02-09
>   
>   API changes, most recent first:
>   
> +2023-03-13 - xxxxxxxxxx - lavu 58.4.100 - hdr_dynamic_metadata.h
> +  Add av_dynamic_hdr_plus_from_t35() and av_dynamic_hdr_plus_to_t35()
> +  functions to convert between raw T.35 payloads containing dynamic
> +  HDR10+ metadata and their parsed representations as AVDynamicHDRPlus.
> +
>   2023-03-02 - xxxxxxxxxx - lavc 60.6.100 - avcodec.h
>     Add FF_PROFILE_EAC3_DDP_ATMOS, FF_PROFILE_TRUEHD_ATMOS,
>     FF_PROFILE_DTS_HD_MA_X and FF_PROFILE_DTS_HD_MA_X_IMAX.
> diff --git a/libavutil/hdr_dynamic_metadata.c b/libavutil/hdr_dynamic_metadata.c
> index 98f399b032..9e35d929c7 100644
> --- a/libavutil/hdr_dynamic_metadata.c
> +++ b/libavutil/hdr_dynamic_metadata.c
> @@ -225,3 +225,148 @@ int av_dynamic_hdr_plus_from_t35(AVDynamicHDRPlus *s, const uint8_t *data,
>   
>       return 0;
>   }
> +
> +int av_dynamic_hdr_plus_to_t35(uint8_t **data, size_t *size, const AVDynamicHDRPlus *s)

I'll change the signature to (const AVDynamicHDRPlus *s, uint8_t **data, 
size_t *size) to have the struct as first argument before pushing if you 
don't mind. It's more in line with the usual order of arguments in the 
project, and also with av_dynamic_hdr_plus_from_t35().